Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust exception message for headers having non-ASCII chars #55886

Merged
merged 1 commit into from
Jul 26, 2021
Merged

adjust exception message for headers having non-ASCII chars #55886

merged 1 commit into from
Jul 26, 2021

Conversation

pedrobsaila
Copy link
Contributor

@pedrobsaila pedrobsaila commented Jul 18, 2021 •
edited by karelz
Loading

Adjust exception message for headers having non-ASCII chars

Fixes #55310

@pedrobsaila pedrobsaila requested a review from a team July 18, 2021 17:53
@ghost
Copy link

ghost commented Jul 18, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Adjust exception message for headers having non-ASCII chars

Issue #55310

Author: pedrobsaila
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@pedrobsaila pedrobsaila mentioned this pull request Jul 19, 2021
Closed
@karelz
Copy link
Member

karelz commented Jul 19, 2021

Thanks for you PR @pedrobsaila!
The CI failures are unrelated known problem - tracked by #55901

@terrajobst terrajobst added the community-contribution Indicates that the PR has been added by a community member label Jul 19, 2021
@karelz
Copy link
Member

karelz commented Jul 26, 2021

Additional DNS test failures are unrelated -- see #56295

@karelz karelz merged commit 158fc37 into dotnet:main Jul 26, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 29, 2021
@pedrobsaila pedrobsaila deleted the Issue55310/adjustExMessage branch August 14, 2021 12:38
@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karelz karelz karelz approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[HTTP/3] QPACK: Need better exception message for non-ASCII values
3 participants
@pedrobsaila @karelz @terrajobst